[compiler-rt] [llvm] [Asan] Add "funclet" OpBundle to generated runtime calls if required by EH personality (PR #82533)

Martin Storsjö via llvm-commits llvm-commits at lists.llvm.org
Sat Mar 9 01:36:38 PST 2024


mstorsjo wrote:

FYI, the new tests broke testing in mingw configurations, see https://github.com/mstorsjo/llvm-mingw/actions/runs/8210784212/job/22462997986
```
clang-19: error: unknown argument: '-EHsc'
```

I presume the `-EHsc` option is vital for the test here, and I guess it's not folded into `%clang_cl_asan`. See 3c1aa20c63548c77ddce3dabc7b25c7c7edccaac and https://github.com/llvm/llvm-project/blob/llvmorg-19-init/compiler-rt/test/asan/lit.cfg.py#L148-L199 for how options that differ are folded into lit substitutions, so the tests keep working on both MinGW and clang-cl style setups.

Not sure how relevant this test is for MinGW style setups though. If nothing else, I'll probably push an added `// UNSUPPORTED: target={{.*-windows-gnu}}` to this test, to unbreak my test setups. Otherwise we could abstract this option behind a substitution like the existing ones.

CC @alvinhochun 

https://github.com/llvm/llvm-project/pull/82533


More information about the llvm-commits mailing list