[llvm] [SimplifyCFG] Fix hoisting problem in SimplifyCFG (PR #78615)

Quentin Dian via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 8 17:15:17 PST 2024


================
@@ -1742,15 +1767,6 @@ bool SimplifyCFGOpt::hoistCommonCodeFromSuccessors(BasicBlock *BB,
       continue;
     }
 
-    SmallVector<Instruction *, 8> OtherInsts;
-    if (SameLevelHoist) { 
----------------
DianQK wrote:

I'm just finding that the code here is getting more complicated. Of course, a big part of the problem here is my previous commits :3.
There is a possibility of ambiguity in this change, and I can verify my thoughts in subsequent PRs.

(Sorry, my github notifications are starting to get hard to sift through the important parts.)

https://github.com/llvm/llvm-project/pull/78615


More information about the llvm-commits mailing list