[llvm] [NFC][AMDGPU] Fix redundant assignment from #77952 (PR #84586)

Krzysztof Drewniak via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 8 16:20:34 PST 2024


https://github.com/krzysz00 created https://github.com/llvm/llvm-project/pull/84586

Someone pointed out a typo (Value* RsrcRes = RsrcRes = ...) in PR the address space 7 lowering, this commit fixes it.

>From 1c64d2701da1fba263c590c1722bf2b2e0914aba Mon Sep 17 00:00:00 2001
From: Krzysztof Drewniak <Krzysztof.Drewniak at amd.com>
Date: Sat, 9 Mar 2024 00:17:50 +0000
Subject: [PATCH] [NFC][AMDGPU] Fix redundant assignment from #77952

Someone pointed out a typo (Value* RsrcRes = RsrcRes = ...) in PR
the address space 7 lowering, this commit fixes it.
---
 llvm/lib/Target/AMDGPU/AMDGPULowerBufferFatPointers.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/llvm/lib/Target/AMDGPU/AMDGPULowerBufferFatPointers.cpp b/llvm/lib/Target/AMDGPU/AMDGPULowerBufferFatPointers.cpp
index 34fcb9aec38fa4..544231cad28016 100644
--- a/llvm/lib/Target/AMDGPU/AMDGPULowerBufferFatPointers.cpp
+++ b/llvm/lib/Target/AMDGPU/AMDGPULowerBufferFatPointers.cpp
@@ -1671,7 +1671,7 @@ PtrParts SplitPtrStructs::visitSelectInst(SelectInst &SI) {
   auto [TrueRsrc, TrueOff] = getPtrParts(True);
   auto [FalseRsrc, FalseOff] = getPtrParts(False);
 
-  Value *RsrcRes = RsrcRes =
+  Value *RsrcRes =
       IRB.CreateSelect(Cond, TrueRsrc, FalseRsrc, SI.getName() + ".rsrc", &SI);
   copyMetadata(RsrcRes, &SI);
   Conditionals.push_back(&SI);



More information about the llvm-commits mailing list