[llvm] [AMDGPU] Simplify renamed BUF instruction definitions. NFC. (PR #84503)

Jay Foad via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 8 08:22:29 PST 2024


================
@@ -2895,28 +2887,25 @@ multiclass MTBUF_Real_AllAddr_gfx11_gfx12_Renamed_Impl<bits<4> op, string real_n
   defm _VBUFFER_OFFSET : VBUFFER_MTBUF_Real_gfx12<op, real_name>;
 }
 
-multiclass MTBUF_Real_AllAddr_gfx11_gfx12<bits<4> op>
- : MTBUF_Real_AllAddr_gfx11_gfx12_Renamed_Impl<op, get_BUF_ps<NAME>.Mnemonic>;
-
-
-multiclass MTBUF_Real_AllAddr_gfx11_gfx12_Renamed<bits<4> op, string real_name>
-  : MTBUF_Real_AllAddr_gfx11_gfx12_Renamed_Impl<op, real_name> {
+multiclass MTBUF_Real_AllAddr_gfx11_gfx12<bits<4> op, string real_name = !tolower(NAME)>
----------------
jayfoad wrote:

True - but I'm not aware of any cases where `!tolower(NAME) != get_BUF_ps<NAME>.Mnemonic`, so I'm not sure if it's a useful abstraction.

https://github.com/llvm/llvm-project/pull/84503


More information about the llvm-commits mailing list