[lld] [lld][AArch64][ELF][PAC] Support AUTH relocations and AUTH ELF marking (PR #72714)

Daniil Kovalev via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 8 02:50:39 PST 2024


kovdan01 wrote:

@MaskRay Thanks for feedback! I've addressed the comments. Regarding

> processAux should be simplified

Please see my comment in [discussion_r1517190622](https://github.com/llvm/llvm-project/pull/72714#discussion_r1517190622). I might miss something, but I don't feel that `processAux` can be significantly simpler. Even if we move all checks that we can to `finalizeAddressDependentContent`, the check of `part.relrAuthDyn` against `nullptr` would still remain in `processAux`, and both `else if` and `else` branches would still be present. I agree that the check against 32-bit addend is redundant here though - it's anyway re-checked later.


https://github.com/llvm/llvm-project/pull/72714


More information about the llvm-commits mailing list