[llvm] [Github] Add repository checks to release-binaries workflow (PR #84437)

Martin Storsjö via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 7 23:49:22 PST 2024


mstorsjo wrote:

> > Warning: To prevent unnecessary workflow runs, scheduled workflows may be disabled automatically. When a public repository is forked, scheduled workflows are disabled by default. In a public repository, scheduled workflows are automatically disabled when no repository activity has occurred in 60 days.
> 
> There's also this screen that shows up on the actions tab when forking at least some repositories recently:
> 
> ![image](https://private-user-images.githubusercontent.com/39388941/311153968-11bda040-44fc-4a30-9292-dae53051058e.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MDk4ODQzMDMsIm5iZiI6MTcwOTg4NDAwMywicGF0aCI6Ii8zOTM4ODk0MS8zMTExNTM5NjgtMTFiZGEwNDAtNDRmYy00YTMwLTkyOTItZGFlNTMwNTEwNThlLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDAzMDglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwMzA4VDA3NDY0M1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWY0NmNlNjRmYTNhNzYwNGI2ZDI0YzBmZmUwNGU3NmE2N2EyYzQ2NTM4NjZmZTk0MzEzNjM1MGY5MjgyM2I2MzMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.P6DVfjZ3Jk0DKg_VMFS0q-pydIiUwyTW38QSXVPW374)
> 
> I can't find anything in the documentation about it though. From what I understand, scheduled workflows are disabled by default, but other workflow events are enabled by default (might have changed at some point though). Given the age of many LLVM forks though, a lot of workflows will just run, including scheduled workflows (hence this patch). We've found it's just good practice to restrict the repository jobs will run on to avoid this issue.

Hmm, right. It's a bit non-obvious that there's a distinction between whether a repo did have actions at the point when it was forked or not, but I guess it makes sense. Thinking further, it would be nice if there was an explicit setting that one can set on one's fork, to disable/enable scheduled actions...

But in any case, restricting the scheduled actions explicitly certainly is best in any case. So +1 from me too.

https://github.com/llvm/llvm-project/pull/84437


More information about the llvm-commits mailing list