[llvm] [llvm-debuginfo-analyzer] Add support for WebAssembly binary format. (PR #82588)

Carlos Alberto Enciso via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 7 12:33:51 PST 2024


CarlosAlbertoEnciso wrote:

I can see that may be the added tests seems like a duplication of the tests for the generic `DWARF` issues.
The main reason for their inclusion (as you pointed out) is to use them as a way to test the initial WebAssembly support and any further development.

There is another point that I think is worth to consider. The specific tests included for the `DWARF/COFF` are binary objects created by `Clang`, `MSVC` and `GCC`. The tests included for the WebAssembly are `.s` generated by `Clang` and converted to binaries by `llvm-mc` (extra step). They are a good set to test the readers supported by the tool.

I would suggest for the initial bootstrap WebAssembly support to keep them, unless that there are another issues like extra testing time, etc. Once the initial support is in place, to work with the WebAssembly people and explore areas that are important to check for divergence.


https://github.com/llvm/llvm-project/pull/82588


More information about the llvm-commits mailing list