[llvm] AMDGPU: Use OtherPredicates for v_dot2_bf16_bf16(f16_f16) pseudo (PR #84354)

Changpeng Fang via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 7 11:38:16 PST 2024


changpeng wrote:

> > LGTM, but this is really unfortunate. Can we try to address dpp predicates?
> 
> let SubtargetPredicate = HasDPP8;
> 
> I am thinking whether we can put hasDPP8 into OtherPredicates (using concat). But we need to be very careful of the ordering this assignment with copy from pseudo to real of OtherPredicates.

let SubtargetPredicate = HasDPP8; // do we really need? 
let AssemblerPredicate = HasDPP8;

Actually why do we need to set both SubtargetPredicate and AssemblerPredicate?  One of them enough?
"AssemblerPredicate = HasDPP8" may also have "overriden" issue on the path. 





https://github.com/llvm/llvm-project/pull/84354


More information about the llvm-commits mailing list