[llvm] [RemoveDIs] Read/write DbgRecords directly from/to bitcode (PR #83251)

[Orlando Cazalet-Hyams via llvm-commits]

================
@@ -2975,6 +2975,17 @@ void Verifier::visitBasicBlock(BasicBlock &BB) {
     Check(I.getParent() == &BB, "Instruction has bogus parent pointer!");
   }
 
+  Check(BB.IsNewDbgInfoFormat == BB.getParent()->IsNewDbgInfoFormat,
+        "BB debug format (new=" + std::to_string(BB.IsNewDbgInfoFormat) +
+            ") should match parent " + BB.getName() + " in " +
+            BB.getParent()->getName());
+  Check(BB.getParent()->IsNewDbgInfoFormat ==
+            BB.getParent()->getParent()->IsNewDbgInfoFormat,
+        "Fn debug format (new=" +
+            std::to_string(BB.getParent()->IsNewDbgInfoFormat) +
+            ") should match parent " + BB.getParent()->getName() + " in " +
+            BB.getParent()->getParent()->getName());
----------------
OCHyams wrote:

Done - I found #84292with this, which makes me worried that this is going to cause some friction when landing. I think it makes sense to move the verifier change to a separate patch -- #84308

https://github.com/llvm/llvm-project/pull/83251