[compiler-rt] [Profile][Windows] Fix flakyness when checking existence of binary id (PR #84196)

Zequan Wu via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 6 09:08:36 PST 2024


ZequanWu wrote:

> lgtm with nit
> 
> Can a build-id be all-zeros? If yes, maybe as a followup we should ensure that it can't.

build-id provided by lld-link is generated by the hash of the object file or pdb: https://github.com/llvm/llvm-project/blob/main/lld/COFF/Writer.cpp#L2171, which is almost impossible to be all 0s.

https://github.com/llvm/llvm-project/pull/84196


More information about the llvm-commits mailing list