[llvm] f53c2f6 - [X86] combineSetCC - use getZExtOrTrunc() to perform the constant folding. NFCI

Simon Pilgrim via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 6 07:47:43 PST 2024


Author: Simon Pilgrim
Date: 2024-03-06T15:47:34Z
New Revision: f53c2f66a76d8a7dcc649d334cd60374b883196f

URL: https://github.com/llvm/llvm-project/commit/f53c2f66a76d8a7dcc649d334cd60374b883196f
DIFF: https://github.com/llvm/llvm-project/commit/f53c2f66a76d8a7dcc649d334cd60374b883196f.diff

LOG: [X86] combineSetCC - use getZExtOrTrunc() to perform the constant folding. NFCI

Added: 
    

Modified: 
    llvm/lib/Target/X86/X86ISelLowering.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Target/X86/X86ISelLowering.cpp b/llvm/lib/Target/X86/X86ISelLowering.cpp
index 6eaaec407dbb08..697e8064dc44c3 100644
--- a/llvm/lib/Target/X86/X86ISelLowering.cpp
+++ b/llvm/lib/Target/X86/X86ISelLowering.cpp
@@ -53266,14 +53266,10 @@ static SDValue combineSetCC(SDNode *N, SelectionDAG &DAG,
         APInt UpperBits = APInt::getBitsSetFrom(SrcVT.getScalarSizeInBits(),
                                                 OpVT.getScalarSizeInBits());
         const TargetLowering &TLI = DAG.getTargetLoweringInfo();
-        auto *C = cast<ConstantSDNode>(RHS);
         if (DAG.MaskedValueIsZero(LHS.getOperand(0), UpperBits) &&
             TLI.isTypeLegal(LHS.getOperand(0).getValueType()))
           return DAG.getSetCC(DL, VT, LHS.getOperand(0),
-                              DAG.getConstant(C->getAPIntValue().zextOrTrunc(
-                                                  SrcVT.getScalarSizeInBits()),
-                                              DL, SrcVT),
-                              CC);
+                              DAG.getZExtOrTrunc(RHS, DL, SrcVT), CC);
       }
 
       // With C as a power of 2 and C != 0 and C != INT_MIN:


        


More information about the llvm-commits mailing list