[llvm] update_test_checks: keep meta variables stable by default (PR #76748)

[Jannik Silvanus via llvm-commits]

Nicolai =?utf-8?q?Hähnle?= <nicolai.haehnle at amd.com>,
Nicolai =?utf-8?q?Hähnle?= <nicolai.haehnle at amd.com>,
Nicolai =?utf-8?q?Hähnle?= <nicolai.haehnle at amd.com>,
Nicolai =?utf-8?q?Hähnle?= <nicolai.haehnle at amd.com>,
Nicolai =?utf-8?q?Hähnle?= <nicolai.haehnle at amd.com>
Message-ID:
In-Reply-To: <llvm.org/llvm/llvm-project/pull/76748 at github.com>


https://github.com/jasilvanus commented:

Thanks, factoring out the matching algorithm into a separate functions is a good change indeed. Also the detailed comments are very helpful.

Having the two similar recursion schemes independent of each other is a bit awkward though.

Is the inner recursion scheme even necessary if the outer one will recurse into intervals between matching edges anyways? It wouldn't be strictly the same as now, because name mapping happens in between, restricting some matching edges, but I think it would also work. Maybe even better, because we'd avoid matches that cannot be used due to name conflicts.

https://github.com/llvm/llvm-project/pull/76748