[llvm] AMDGPU: Proper use of HasImageInsts in vimage inst definitions, NFC (PR #83884)

Jay Foad via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 6 00:06:12 PST 2024


================
@@ -966,7 +966,7 @@ class VIMAGE_Atomic_gfx12_Renamed<mimgopc op, string opcode, string renamed,
                                   RegisterClass DataRC, int num_addrs,
                                   bit enableDisasm = 0>
    : VIMAGE_Atomic_gfx12<op, renamed, DataRC, num_addrs, enableDisasm>,
-     MnemonicAlias<opcode, renamed>, Requires<[isGFX12Plus]>;
+     MnemonicAlias<opcode, renamed>, Requires<[isGFX12Plus, HasImageInsts]>;
----------------
jayfoad wrote:

Do you actually need to change the predicates on the alias?

https://github.com/llvm/llvm-project/pull/83884


More information about the llvm-commits mailing list