[llvm] [NVPTX] Skip processing BasicBlocks with single unreachable instruction in `nvptx-lower-unreachable` pass. (PR #72641)
Artem Belevich via llvm-commits
llvm-commits at lists.llvm.org
Tue Mar 5 14:13:43 PST 2024
================
@@ -138,7 +138,19 @@ bool NVPTXLowerUnreachable::runOnFunction(Function &F) {
InlineAsm *Exit = InlineAsm::get(ExitFTy, "exit;", "", true);
bool Changed = false;
- for (auto &BB : F)
+
+ // In scenarios where a BasicBlock contains only one unreachable instruction,
+ // the joint action of nvptx-isel and unreachable-mbb-elimination
+ // effectively optimizes the BasicBlock out. However, adding an exit
+ // command to such a BasicBlock, as suggested by this pass, preserves it
+ // within the Control Flow Graph (CFG), thereby negatively impacting size and
+ // performance. To counteract this undesirable consequence, we choose to
+ // refrain from processing BasicBlocks with just one unreachable instruction
+ // in this pass.
+
----------------
Artem-B wrote:
Or reintroduce `-nvptx-exit-on-unreachable=0` option. This would be a relatively uncontroversial change.
> I'd be happy to see issues the patch fixes, if you have access to any.
The original patch description provides a good overview https://reviews.llvm.org/D152789
It all started here: https://bugs.llvm.org/show_bug.cgi?id=27738
Julia folks eventually came up with a concise reproducer:
https://github.com/JuliaGPU/CUDAnative.jl/issues/4
Since then we've attempted to keep CFG structured (it helped a lot, but not completely.)
Over time the issue kept popping up, again, and again. E.g. we had to disable some loop transform passes that happened to trigger the issue.
7 years later we've finally figured out what seems to be triggering ptxas miscompilation.
https://github.com/llvm/llvm-project/pull/72641
More information about the llvm-commits
mailing list