[llvm] [benchmark] Delete WORKSPACE bzl files (PR #84013)
via llvm-commits
llvm-commits at lists.llvm.org
Tue Mar 5 05:20:57 PST 2024
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-third-party-benchmark
Author: Jordan Rupprecht (rupprecht)
<details>
<summary>Changes</summary>
As like 48d868493fa74025e7768afacdbbbd3ea9c82468, `WORKSPACE` is another bazel-specific file that is unused. LLVM's bazel configuration is entirely in `utils/bazel`.
---
Full diff: https://github.com/llvm/llvm-project/pull/84013.diff
2 Files Affected:
- (removed) third-party/benchmark/WORKSPACE (-30)
- (modified) third-party/update_benchmark.sh (+1)
``````````diff
diff --git a/third-party/benchmark/WORKSPACE b/third-party/benchmark/WORKSPACE
deleted file mode 100644
index 256207022597f5..00000000000000
--- a/third-party/benchmark/WORKSPACE
+++ /dev/null
@@ -1,30 +0,0 @@
-workspace(name = "com_github_google_benchmark")
-
-load("//:bazel/benchmark_deps.bzl", "benchmark_deps")
-
-benchmark_deps()
-
-load("@rules_foreign_cc//foreign_cc:repositories.bzl", "rules_foreign_cc_dependencies")
-
-rules_foreign_cc_dependencies()
-
-load("@rules_python//python:repositories.bzl", "py_repositories")
-
-py_repositories()
-
-load("@rules_python//python:pip.bzl", "pip_parse")
-
-pip_parse(
- name = "tools_pip_deps",
- requirements_lock = "//tools:requirements.txt",
-)
-
-load("@tools_pip_deps//:requirements.bzl", "install_deps")
-
-install_deps()
-
-new_local_repository(
- name = "python_headers",
- build_file = "@//bindings/python:python_headers.BUILD",
- path = "<PYTHON_INCLUDE_PATH>", # May be overwritten by setup.py.
-)
diff --git a/third-party/update_benchmark.sh b/third-party/update_benchmark.sh
index cda0bcfb1a7ac2..047efd945a86b5 100755
--- a/third-party/update_benchmark.sh
+++ b/third-party/update_benchmark.sh
@@ -13,4 +13,5 @@ git clone https://github.com/google/benchmark.git
rm -rf benchmark/.git*
find benchmark/ -name BUILD -delete
find benchmark/ -name BUILD.bazel -delete
+find benchmark/ -name WORKSPACE -delete
``````````
</details>
https://github.com/llvm/llvm-project/pull/84013
More information about the llvm-commits
mailing list