[llvm] [Dexter] Extend XFAIL of Dexter tests to all MacOS architectures. (PR #83936)

[via llvm-commits]

https://github.com/dyung created https://github.com/llvm/llvm-project/pull/83936

I am trying to bring up a MacOS buildbot targeting x86 and noticed that two Dexter tests were failing, `cross-project-tests/debuginfo-tests/llgdb-tests/static-member.cpp` and `cross-project-tests/debuginfo-tests/llgdb-tests/static-member-2.cpp`. Looking in the history for these tests, they were XFAILed for Apple Silicon in 9c46606. To test, I locally removed the XFAIL on my local Apple Silicon machine, and the errors produced match those my buildbot on x86 is producing.

For example:
```
FAIL: cross-project-tests :: debuginfo-tests/llgdb-tests/static-member.cpp (132 of 137)
******************** TEST 'cross-project-tests :: debuginfo-tests/llgdb-tests/static-member.cpp' FAILED ********************
Exit Code: 1

Command Output (stdout):
--
Debugger output was:
error: 'delete' is not a valid command.
imported lldb from: "/Applications/Xcode.app/Contents/SharedFrameworks/LLDB.framework/Resources/Python"
>  delete breakpoints
None
>  break static-member.cpp:33
SBBreakpoint: id = 1, file = 'static-member.cpp', line = 33, exact_match = 0, locations = 1
>  r
success
>  ptype MyClass
class MyClass {
    static const int a = 4;
    static int b;
    static int c;
public:
    int d;
}
>  p MyClass::a
(const int) $0 = 4
>  p MyClass::c
(int) $1 = 15
> quit

--
Command Output (stderr):
--
RUN: at line 1: /Users/dyung/src/git/llvm/build/bin/clang --driver-mode=g++ --target=arm64-apple-darwin23.3.0 -O0 -g /Users/dyung/src/git/llvm/cross-project-tests/debuginfo-tests/llgdb-tests/static-member.cpp -o /Users/dyung/src/git/llvm/build/projects/cross-project-tests/debuginfo-tests/llgdb-tests/Output/static-member.cpp.tmp -c
+ /Users/dyung/src/git/llvm/build/bin/clang --driver-mode=g++ --target=arm64-apple-darwin23.3.0 -O0 -g /Users/dyung/src/git/llvm/cross-project-tests/debuginfo-tests/llgdb-tests/static-member.cpp -o /Users/dyung/src/git/llvm/build/projects/cross-project-tests/debuginfo-tests/llgdb-tests/Output/static-member.cpp.tmp -c
RUN: at line 2: /Users/dyung/src/git/llvm/build/bin/clang --driver-mode=g++ --target=arm64-apple-darwin23.3.0 /Users/dyung/src/git/llvm/build/projects/cross-project-tests/debuginfo-tests/llgdb-tests/Output/static-member.cpp.tmp -o /Users/dyung/src/git/llvm/build/projects/cross-project-tests/debuginfo-tests/llgdb-tests/Output/static-member.cpp.tmp.out
+ /Users/dyung/src/git/llvm/build/bin/clang --driver-mode=g++ --target=arm64-apple-darwin23.3.0 /Users/dyung/src/git/llvm/build/projects/cross-project-tests/debuginfo-tests/llgdb-tests/Output/static-member.cpp.tmp -o /Users/dyung/src/git/llvm/build/projects/cross-project-tests/debuginfo-tests/llgdb-tests/Output/static-member.cpp.tmp.out
RUN: at line 3: /Users/dyung/src/git/llvm/cross-project-tests/debuginfo-tests/llgdb-tests/test_debuginfo.pl /Users/dyung/src/git/llvm/cross-project-tests/debuginfo-tests/llgdb-tests/static-member.cpp /Users/dyung/src/git/llvm/build/projects/cross-project-tests/debuginfo-tests/llgdb-tests/Output/static-member.cpp.tmp.out
+ /Users/dyung/src/git/llvm/cross-project-tests/debuginfo-tests/llgdb-tests/test_debuginfo.pl /Users/dyung/src/git/llvm/cross-project-tests/debuginfo-tests/llgdb-tests/static-member.cpp /Users/dyung/src/git/llvm/build/projects/cross-project-tests/debuginfo-tests/llgdb-tests/Output/static-member.cpp.tmp.out
/Users/dyung/src/git/llvm/cross-project-tests/debuginfo-tests/llgdb-tests/static-member.cpp:11:11: error: CHECK: expected string not found in input
// CHECK: static const int a;
          ^
/Users/dyung/src/git/llvm/build/projects/cross-project-tests/debuginfo-tests/llgdb-tests/Output/static-member.cpp.gdb.output:10:16: note: scanning from here
class MyClass {
               ^
/Users/dyung/src/git/llvm/build/projects/cross-project-tests/debuginfo-tests/llgdb-tests/Output/static-member.cpp.gdb.output:11:2: note: possible intended match here
 static const int a = 4;
 ^

Input file: /Users/dyung/src/git/llvm/build/projects/cross-project-tests/debuginfo-tests/llgdb-tests/Output/static-member.cpp.gdb.output
Check file: /Users/dyung/src/git/llvm/cross-project-tests/debuginfo-tests/llgdb-tests/static-member.cpp

-dump-input=help explains the following input dump.

Input was:
<<<<<<
            .
            .
            .
            5: > break static-member.cpp:33 
            6: SBBreakpoint: id = 1, file = 'static-member.cpp', line = 33, exact_match = 0, locations = 1 
            7: > r 
            8: success 
            9: > ptype MyClass 
           10: class MyClass { 
check:11'0                    X error: no match found
           11:  static const int a = 4; 
check:11'0     ~~~~~~~~~~~~~~~~~~~~~~~~~
check:11'1      ?                        possible intended match
           12:  static int b; 
check:11'0     ~~~~~~~~~~~~~~~
           13:  static int c; 
check:11'0     ~~~~~~~~~~~~~~~
           14: public: 
check:11'0     ~~~~~~~~
           15:  int d; 
check:11'0     ~~~~~~~~
           16: } 
check:11'0     ~~
            .
            .
            .
>>>>>>
```
This matches what my x86 MacOS buildbot seems to be hitting for this test https://lab.llvm.org/staging/#/builders/188/builds/307/steps/6/logs/FAIL__cross-project-tests__static-member_cpp.

The failing output for static-member-2.cpp also seems to match between my Apple Silicon and x86 machines, so I think it makes sense to extend the XFAIL to all `system-darwin` targets, and not just aarch64.

>From 1155ccbce6faceead0e333abb5154a08eea4d6c9 Mon Sep 17 00:00:00 2001
From: Douglas Yung <dyung+github at fastmail.fm>
Date: Mon, 4 Mar 2024 17:25:20 -0800
Subject: [PATCH] [Dexter] Extend XFAIL of Dexter tests to all MacOS
 architectures.

---
 .../debuginfo-tests/llgdb-tests/static-member-2.cpp             | 2 +-
 .../debuginfo-tests/llgdb-tests/static-member.cpp               | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/cross-project-tests/debuginfo-tests/llgdb-tests/static-member-2.cpp b/cross-project-tests/debuginfo-tests/llgdb-tests/static-member-2.cpp
index 79ff74cb2d0aeb..3f11ae018fc858 100644
--- a/cross-project-tests/debuginfo-tests/llgdb-tests/static-member-2.cpp
+++ b/cross-project-tests/debuginfo-tests/llgdb-tests/static-member-2.cpp
@@ -2,7 +2,7 @@
 // RUN: %clangxx %target_itanium_abi_host_triple %t -o %t.out
 // RUN: %test_debuginfo %s %t.out
 // XFAIL: gdb-clang-incompatibility
-// XFAIL: system-darwin && target-aarch64
+// XFAIL: system-darwin
 
 // DEBUGGER: delete breakpoints
 // DEBUGGER: break static-member.cpp:33
diff --git a/cross-project-tests/debuginfo-tests/llgdb-tests/static-member.cpp b/cross-project-tests/debuginfo-tests/llgdb-tests/static-member.cpp
index abfa8e3337f64d..57316dfd640404 100644
--- a/cross-project-tests/debuginfo-tests/llgdb-tests/static-member.cpp
+++ b/cross-project-tests/debuginfo-tests/llgdb-tests/static-member.cpp
@@ -2,7 +2,7 @@
 // RUN: %clangxx %target_itanium_abi_host_triple %t -o %t.out
 // RUN: %test_debuginfo %s %t.out
 // XFAIL: !system-darwin && gdb-clang-incompatibility
-// XFAIL: system-darwin && target-aarch64
+// XFAIL: system-darwin
 // DEBUGGER: delete breakpoints
 // DEBUGGER: break static-member.cpp:33
 // DEBUGGER: r