[llvm] [llvm-mca][AMDGPU] Retire instructions that have issue carry over correctly (PR #83881)

Min-Yih Hsu via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 4 17:16:22 PST 2024


================
@@ -329,6 +335,17 @@ void InOrderIssueStage::updateCarriedOver() {
   else
     Bandwidth -= CarryOver;
 
+  // updateIssuedInst did not handle executed if issue had carry over.
+  if (CarriedOver.getInstruction()->isExecuted()) {
+    PRF.onInstructionExecuted(&IS);
+    LSU.onInstructionExecuted(IR);
+    notifyEvent<HWInstructionEvent>(
+        HWInstructionEvent(HWInstructionEvent::Executed, IR));
+    LLVM_DEBUG(dbgs() << "[E] Instruction #" << IR << " is executed\n");
----------------
mshockwave wrote:

Could we use notifyInstructionExecuted here? I think it's doing the same thing

https://github.com/llvm/llvm-project/pull/83881


More information about the llvm-commits mailing list