[llvm] [RemoveDIs] Read/write DbgRecords directly from/to bitcode (PR #83251)

Jeremy Morse via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 4 10:10:28 PST 2024


================
@@ -615,6 +616,8 @@ Value *IRLinker::materialize(Value *V, bool ForIndirectSymbol) {
 
   // If we already created the body, just return.
   if (auto *F = dyn_cast<Function>(New)) {
+    if (auto *OldFunc = dyn_cast<Function>(SGV))
+      F->IsNewDbgInfoFormat = OldFunc->IsNewDbgInfoFormat;
----------------
jmorse wrote:

I've had this hunk floating around in my worktrees for a while and over time I've grown worried about it -- AFAIUI this function hits the bitcode materializer, presumably that's the correct point to work out what the correct RemoveDIs/DDD mode we should be in, rather than here? This is part of the wider problem of drawing a line through LLVM that we want to loop-in to using RemoveDIs, perhaps there's just no good solution at this stage?

https://github.com/llvm/llvm-project/pull/83251


More information about the llvm-commits mailing list