[llvm] [LLVM][DWARF] Make dwarf::getDebugNamesBucketCount return a pair. (PR #83047)

Fangrui Song via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 1 11:58:49 PST 2024


================
@@ -38,7 +38,9 @@ void AccelTableBase::computeBucketCount() {
   for (const auto &E : Entries)
     Uniques.push_back(E.second.HashValue);
 
-  BucketCount = llvm::dwarf::getDebugNamesBucketCount(Uniques, UniqueHashCount);
+  auto Counts = llvm::dwarf::getDebugNamesBucketAndHashCount(Uniques);
----------------
MaskRay wrote:

I made the simplification already. Sometimes reviewers may click "Accept" and expect some minor code suggestions will be adopted before landing. It's worth paying attention to these comments.

(For both #82153 and this #83047, my comments were created before the patch landed. Don't worry. We all made mistakes.)

https://github.com/llvm/llvm-project/pull/83047


More information about the llvm-commits mailing list