[llvm] [AMDGPU] Rename hasGFX12Enc to hasRestrictedSOffset in BUF definitions. NFC. (PR #83434)
Jay Foad via llvm-commits
llvm-commits at lists.llvm.org
Fri Mar 1 02:47:33 PST 2024
jayfoad wrote:
> LGTM. A refactoring suggestion, could be a separate patch. Make hasRestrictedSOffset a field of MTBUF_Pseudo, MUBUF_Pseudo and MUBUF_AtomicPseudo. let InOperandList = getMUBUFIns<...> as a field in those classes. override hasRestrictedSOffset with an outer let where the instructions are actually defined. This would avoid having to pass hasRestrictedSOffset as a parameter super far through the inheritance chain. Or otherwise pack hasRestrictedSOffset into a struct with other fields?
Thanks, sounds promising but I can't quite see how to make it work. `let InOperandList = getMUBUFIns<...>` doesn't seem quite right since getMUBUFIns only provides a prefix of the InOperandList in some cases - MUBUF_Load_Pseudo concatenates more stuff onto the end to make the full InOperandList. Please feel free to tackle it yourself :)
https://github.com/llvm/llvm-project/pull/83434
More information about the llvm-commits
mailing list