[llvm] [Analysis][ValueTracking] Unify most of the tracking between AssumptionCache and DomConditionCache (PR #83161)
Nikita Popov via llvm-commits
llvm-commits at lists.llvm.org
Fri Mar 1 00:39:09 PST 2024
================
@@ -813,6 +813,8 @@ void llvm::computeKnownBitsFromContext(const Value *V, KnownBits &Known,
if (!isValidAssumeForContext(I, Q.CxtI, Q.DT))
continue;
+ // Change to `computeKnownBitsFromCond` if we start supporting assume of
+ // logic op in ConditionCacheUtil.
----------------
nikic wrote:
Due to recent unfortunate events, I would recommend against leaving any TODO/FIXME comments unless you are very sure that resolving them is actually valuable. Otherwise there is too much risk that new contributors will try to "fix" them without having the necessary background.
https://github.com/llvm/llvm-project/pull/83161
More information about the llvm-commits
mailing list