[compiler-rt] [compiler-rt][Fuzzer] SetThreadName windows implementation new try. (PR #76761)

[Mike Hommey via llvm-commits]

glandium wrote:

This interestingly broken our compiler-rt builds downstream:
```
[task 2024-03-01T02:17:28.933Z] /builds/worker/fetches/clang/bin/clang-cl --target=x86_64-pc-windows-msvc  /nologo -TP  -I/builds/worker/fetches/llvm-project/compiler-rt/lib/fuzzer/../../include -D_CRT_SECURE_NO_WARNINGS --target=x86_64-windows-msvc -fms-compatibility-version=19.27 -vctoolsversion 14.29.30133 -winsdkversion 10.0.19041.0 -winsysroot /builds/worker/fetches/vs -Xclang -ivfsoverlay -Xclang /builds/worker/build/winsdk_vfs_overlay.yaml /DWIN32 /D_WINDOWS /EHsc /W4 -Wno-unused-parameter /O2 /Ob2 /DNDEBUG -MT -fno-builtin -fno-sanitize=safe-stack -fno-lto /Oy- /GS- /Zc:threadSafeInit- -Wthread-safety -Wthread-safety-reference -Wthread-safety-beta /Z7 -Wno-gnu -Wno-variadic-macros -Wno-c99-extensions /wd4146 /wd4291 /wd4391 /wd4722 /wd4800 -D_HAS_EXCEPTIONS=0 -std:c++17 /showIncludes /Folib/fuzzer/CMakeFiles/RTfuzzer.x86_64.dir/FuzzerUtilWindows.cpp.obj /Fdlib/fuzzer/CMakeFiles/RTfuzzer.x86_64.dir/ -c -- /builds/worker/fetches/llvm-project/compiler-rt/lib/fuzzer/FuzzerUtilWindows.cpp
[task 2024-03-01T02:17:28.933Z] In file included from /builds/worker/fetches/llvm-project/compiler-rt/lib/fuzzer/FuzzerUtilWindows.cpp:21:
[task 2024-03-01T02:17:28.933Z] In file included from /builds/worker/fetches/vs/Windows Kits/10/Include/10.0.19041.0/um/libloaderapi.h:18:
[task 2024-03-01T02:17:28.933Z] In file included from /builds/worker/fetches/vs/Windows Kits/10/Include/10.0.19041.0/shared/minwindef.h:182:
[task 2024-03-01T02:17:28.933Z] /builds/worker/fetches/vs/Windows Kits/10/Include/10.0.19041.0/um/winnt.h(173,2): error: "No Target Architecture"
[task 2024-03-01T02:17:28.933Z]   173 | #error "No Target Architecture"
[task 2024-03-01T02:17:28.933Z]       |  ^
```

Interestingly, the contents of winnt.h around that line are:
```
#if defined(_AMD64_) || defined(_X86_)
#define PROBE_ALIGNMENT( _s ) TYPE_ALIGNMENT( DWORD )
#elif defined(_IA64_) || defined(_ARM_) || defined(_ARM64_)

//
// TODO: WOWXX - Unblock ARM. Make all alignment checks DWORD for now.
//

#define PROBE_ALIGNMENT( _s ) TYPE_ALIGNMENT( DWORD )
#elif !defined(RC_INVOKED)
#error "No Target Architecture"
#endif
```

which suggests _AMD64_ is not set, which only happens if atlconv.h is included, which I guess is not happening.

https://github.com/llvm/llvm-project/pull/76761