[llvm] [Analysis][ValueTracking] Unify most of the tracking between AssumptionCache and DomConditionCache (PR #83161)

via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 29 09:33:07 PST 2024


================
@@ -813,6 +813,8 @@ void llvm::computeKnownBitsFromContext(const Value *V, KnownBits &Known,
     if (!isValidAssumeForContext(I, Q.CxtI, Q.DT))
       continue;
 
+    // Change to `computeKnownBitsFromCond` if we start supporting assume of
+    // logic op in ConditionCacheUtil.
----------------
goldsteinn wrote:

Something like `assume(a || b)` can exist.

I'm happy to drop supporting it in this patch, but would prefer to keep comments indicating the steps necessary should we change out mind.

that okay?

https://github.com/llvm/llvm-project/pull/83161


More information about the llvm-commits mailing list