[llvm] [AMDGPU] Fix conformance issue for ctlz. (PR #83170)
Leon Clark via llvm-commits
llvm-commits at lists.llvm.org
Thu Feb 29 07:10:49 PST 2024
PeddleSpam wrote:
> > Remove LSH transform and restore original lowering.
> > Fixes conformance issue in [77615](https://github.com/llvm/llvm-project/pull/77615).
>
> This doesn't explain what the conformance issue is :) You should add a few words about that.
>
> Also, does this really restore the original lowering? The original lowering was not custom, IIUC. It seems this patch only brings the custom lowering closer to the original one, but it's not entirely equivalent to a revert of #77615.
I've edited my comment to mention integer_ops test failures. These tests are not part of LLVM.
[#77615](https://github.com/llvm/llvm-project/pull/77615) used this lowering in its original incarnation. The LSH lowering was suggested in review but ultimately led to failures in conformance testing.
https://github.com/llvm/llvm-project/pull/83170
More information about the llvm-commits
mailing list