[lld] [lld-macho] Implement ObjC category merging (-objc_category_merging) (PR #82928)
Kyungwoo Lee via llvm-commits
llvm-commits at lists.llvm.org
Wed Feb 28 22:57:57 PST 2024
https://github.com/kyulee-com commented:
Thanks for working on this!
I didn't finish the review, but the followings are a few high-level comments.
- I think instead of `isLinkOptimizedAway`, `live` can be simply updated.
- There are many boolean returns, which I don't think necessary. I prefer assert or fail/error if parsing fails, etc. Basically there is no point when it returns false (ignoring failure). I'd restructure most of functions APIs.
- The test simply checks the category symbol, but didn't validate the contents although there are many code to merge contents.
- I'd suggest to update comments as possible and make code consistent and concise.
https://github.com/llvm/llvm-project/pull/82928
More information about the llvm-commits
mailing list