[lld] [lld][AArch64][ELF][PAC] Support AUTH relocations and AUTH ELF marking (PR #72714)

[Daniil Kovalev via llvm-commits]

kovdan01 wrote:

@MaskRay Thanks for your feedback, see answers to your comments and new commits addressing the issues.

I want to bring attention to [discussion_r1495128934](https://github.com/llvm/llvm-project/pull/72714/#discussion_r1495128934) - I've discovered a case with large addends (fitting 32-bits, but large, like 0x7fffffff) which was not handled properly. See e9b53374522fca221414aac3d5a3b225e7fc73d4 for the fix. You can find all the details in the commit message, comments in code and tests.

There are also several old comments which are still unresolved but IMO fixed. I would be glad if you look through them and let me know if I've missed something and some issues are still there. For the fixed issues, I kindly ask you to resolve threads - it would be much easier to look through the PR if only unfixed comments are unresolved.

- [discussion_r1423344812](https://github.com/llvm/llvm-project/pull/72714/#discussion_r1423344812) - fixed in 589c6455a929f41ed3a79fc7d91119586eb1ee7b
- [discussion_r1423345089](https://github.com/llvm/llvm-project/pull/72714/#discussion_r1423345089) - fixed in 594f8a0e8331b5d11f3efc58fcaa7eae4b9fd7b4
- [discussion_r1423345225](https://github.com/llvm/llvm-project/pull/72714/#discussion_r1423345225) - it looks like we've achieved some consensus in test naming and current test names (aarch64-bti-pac-cli-error.s, aarch64-feature-pauth.s, aarch64-reloc-pauth-ro.s, aarch64-reloc-pauth.s) seem OK
- [discussion_r1423345733](https://github.com/llvm/llvm-project/pull/72714/#discussion_r1423345733) - test directives count looks reasonable now: not too little, not too many of them
- [discussion_r1472312886](https://github.com/llvm/llvm-project/pull/72714/#discussion_r1472312886) - fixed in de73eae53481bb805fbabe97a38055ebaad934de
- [discussion_r1472313816](https://github.com/llvm/llvm-project/pull/72714/#discussion_r1472313816) - fixed in de73eae53481bb805fbabe97a38055ebaad934de
- [discussion_r1472314138](https://github.com/llvm/llvm-project/pull/72714/#discussion_r1472314138) - fixed in de73eae53481bb805fbabe97a38055ebaad934de
- [discussion_r1485223221](https://github.com/llvm/llvm-project/pull/72714/#discussion_r1485223221) - fixed in aff3a96d4383b6aa930d4d21db949b3b459f2163
- [discussion_r1485223337](https://github.com/llvm/llvm-project/pull/72714/#discussion_r1485223337) - fixed in ec1c6322341f3f25f3ad0070810c4a90d188c3b5
- [discussion_r1485224296](https://github.com/llvm/llvm-project/pull/72714/#discussion_r1485224296) - fixed in 4e53afaa50e63466263d0697e0e2a335d281dbf6
- [discussion_r1485224665](https://github.com/llvm/llvm-project/pull/72714/#discussion_r1485224665) - fixed in aff3a96d4383b6aa930d4d21db949b3b459f2163
- [discussion_r1485225472](https://github.com/llvm/llvm-project/pull/72714/#discussion_r1485225472) - fixed in aff3a96d4383b6aa930d4d21db949b3b459f2163
- [discussion_r1485226064](https://github.com/llvm/llvm-project/pull/72714/#discussion_r1485226064) - fixed in aff3a96d4383b6aa930d4d21db949b3b459f2163
- [discussion_r1485231933](https://github.com/llvm/llvm-project/pull/72714/#discussion_r1485231933) - fixed in 4e53afaa50e63466263d0697e0e2a335d281dbf6
- [discussion_r1485233154](https://github.com/llvm/llvm-project/pull/72714/#discussion_r1485233154) - fixed in aff3a96d4383b6aa930d4d21db949b3b459f2163 and not even relevant after 1448a4a4e0e3cb70358558579e97fce3f0990356
- [discussion_r1485234537](https://github.com/llvm/llvm-project/pull/72714/#discussion_r1485234537) - fixed in aff3a96d4383b6aa930d4d21db949b3b459f2163 and 1448a4a4e0e3cb70358558579e97fce3f0990356
- [discussion_r1485235734](https://github.com/llvm/llvm-project/pull/72714/#discussion_r1485235734) - fixed in 4e53afaa50e63466263d0697e0e2a335d281dbf6
- [discussion_r1485237672](https://github.com/llvm/llvm-project/pull/72714/#discussion_r1485237672) - fixed in 4e53afaa50e63466263d0697e0e2a335d281dbf6
- [discussion_r1485239935](https://github.com/llvm/llvm-project/pull/72714/#discussion_r1485239935) - fixed in aff3a96d4383b6aa930d4d21db949b3b459f2163
- [discussion_r1485240613](https://github.com/llvm/llvm-project/pull/72714/#discussion_r1485240613) - fixed in 4e53afaa50e63466263d0697e0e2a335d281dbf6
- [discussion_r1485243679](https://github.com/llvm/llvm-project/pull/72714/#discussion_r1485243679) - fixed in 4e53afaa50e63466263d0697e0e2a335d281dbf6



https://github.com/llvm/llvm-project/pull/72714