[llvm] [AArch64][LV][SLP] Vectorizers use getFRemInstrCost for frem costs (PR #82488)

Paschalis Mpeis via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 28 09:25:28 PST 2024


paschalis-mpeis wrote:

> Same applies to the newly introduced function

True, but the newly introduced function makes it quite explicit to it's users.
They can't use it by mistake without noticing. And now we'll have it in two places that we know are OK.

> This is not the problem of this patch, it is the issue of future patches and the authors of these patches should handle it correctly.

Exactly. Until codegen can fully handle frem, we'd prefer not to set any 'traps' for future patches and authors, and instead be very explicit about it.

https://github.com/llvm/llvm-project/pull/82488


More information about the llvm-commits mailing list