[llvm] [SimplifyCFG] Fix hoisting problem in SimplifyCFG (PR #78615)

via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 28 09:07:26 PST 2024


================
@@ -1742,15 +1767,6 @@ bool SimplifyCFGOpt::hoistCommonCodeFromSuccessors(BasicBlock *BB,
       continue;
     }
 
-    SmallVector<Instruction *, 8> OtherInsts;
-    if (SameLevelHoist) { 
----------------
RouzbehPaktinat wrote:

What is your idea @nikic ?
It's reasonable to make those changes but I assume it will take a bit time and won't be able to do it immediately (probably I will face with some corner cases and need to resolve them). This PR has been open for a long time and we have good results in terms of code size. What do you suggest?

https://github.com/llvm/llvm-project/pull/78615


More information about the llvm-commits mailing list