[llvm] [TableGen] Extend direct lookup to instruction values in generic tables. (PR #80486)
Jason Eckhardt via llvm-commits
llvm-commits at lists.llvm.org
Wed Feb 28 08:45:56 PST 2024
nvjle wrote:
> > > CC @nvjle (not sure if notifications are sent without explicit mention)
> >
> >
> > Thanks @piotrAMD, I'll look into this in detail sometime this week. At first glance it does seem there may be a potential problem, but there is no actual failure that I can see. All testing is good thus far, including for AMDGPU. But we surely want this to be bullet proof.
>
> Thanks, I'll try to come up with a reproducer.
Hi @piotrAMD, I've revisited this and agree with your reasoning and posted this tiny patch accordingly: https://github.com/llvm/llvm-project/pull/83284. All tests (including the backend I'm working on which is at least as SearchableTable-heavy as AMDGPU) are good and `WMMAOpcode2AddrMappingTable` isn't actually affected one way or the other.
https://github.com/llvm/llvm-project/pull/80486
More information about the llvm-commits
mailing list