[llvm] [llvm-objcopy] Add llvm-objcopy option --ignore-symbol (PR #80873)
James Henderson via llvm-commits
llvm-commits at lists.llvm.org
Wed Feb 28 00:25:45 PST 2024
https://github.com/jh7370 commented:
Implementation basically looks good. You need to update the PR title and description for the new option names, since that is used in the final commit message.
As --skip-symbol is something you might expect to work for other formats (it might be implemented later), it should be added to the list of options that generate an error when a non-ELF format is detected in the (I think) config manager code.
You also should have a test case that tests multiple --skip-symbol options specified at the same time. Finally, I think there's value to test --skip-symbol + --set-symbol-visibility explicitly, to demonstrate their order.
https://github.com/llvm/llvm-project/pull/80873
More information about the llvm-commits
mailing list