[llvm] Refactoring changes to support emitting call graph section (PR #83176)

Felipe de Azevedo Piovezan via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 27 14:49:14 PST 2024


================
@@ -888,8 +888,10 @@ EmitSchedule(MachineBasicBlock::iterator &InsertPos) {
     }
 
     if (MI->isCandidateForCallSiteEntry() &&
-        DAG->getTarget().Options.EmitCallSiteInfo)
-      MF.addCallArgsForwardingRegs(MI, DAG->getCallSiteInfo(Node));
+        DAG->getTarget().Options.EmitCallSiteInfo) {
+      // MF.addCallArgsForwardingRegs(MI, DAG->getCallSiteInfo(Node));
+      MF.addCallSiteInfo(MI, DAG->getCallSiteInfo(Node));
+    }
----------------
felipepiovezan wrote:

yup, more generally we should not commit commented out code.

I also agree this deserves to be split as two PRs and merged independently.

https://github.com/llvm/llvm-project/pull/83176


More information about the llvm-commits mailing list