[llvm] [DirectX][NFC] Simplified DXIL Operation mapping to LLVM or DirectX intrinsics in DXIL.td. (PR #83193)

Justin Bogner via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 27 14:36:52 PST 2024


https://github.com/bogner commented:

This is a good start!

Could you please change the commit/PR description to describe what this is accomplishing at a high level rather than a list of the changes in the diff? That is to say, something along the lines of "Instead of duplicating definitions of LLVM and DirectX intrinsics with equivalent DXIL op definitions in tablegen, rely on a simple mapping between the two and derive the DXIL op definitions structurally" would be an improvement. Also it's generally best to try to keep the commit title under 80 characters if you can.

https://github.com/llvm/llvm-project/pull/83193


More information about the llvm-commits mailing list