[llvm] [Analysis][ValueTracking] Unify most of the tracking between AssumptionCache and DomConditionCache (PR #83161)

via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 27 11:36:23 PST 2024


goldsteinn wrote:

> > > > This makes some generalizations that I am not happy with. In particular a) assumes should not recursive into logical ops and b) dom conds should require constant RHS in comparisons.
> > > 
> > > 
> > > why no `logicop` for assume?
> > 
> > 
> > https://github.com/llvm/llvm-project/blob/9ca8db352d22444feabd859380252f13826a8aff/llvm/lib/Transforms/InstCombine/InstCombineCalls.cpp#L2828-L2847
> 
> What about `assume(A || B)` / `assume(!(A && B))`?

Dropped assume(logicop). Left comment/potential todo.

https://github.com/llvm/llvm-project/pull/83161


More information about the llvm-commits mailing list