[llvm] change contents of ScalarEvolution from private to protected (PR #83052)

[William Moses via llvm-commits]

wsmoses wrote:

Yes that’s correct (and the results will inform what function Enzyme will
generate).

On Tue, Feb 27, 2024 at 2:10 PM Nikita Popov ***@***.***>
wrote:

> @nikic <https://github.com/nikic> yeah I'm not sure willreturn will work
> in this case, since the original input function may not be willreturn. E.g.
> we don't re-optimize the function (including from other calling contexts)
> with willreturn, but this addition is only needed for cache size
> calculations which are only used if at runtime the function returned from
> the original code.
>
> Ah, you are running SCEV on the original function, not the new one Enzyme
> is generating? Then yeah, marking it as willreturn wouldn't be right and
> you do need some kind of flag or hook.
>
> —
> Reply to this email directly, view it on GitHub
> <https://github.com/llvm/llvm-project/pull/83052#issuecomment-1967416993>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AAJTUXEGWWYZISBB2VY3AILYVYVQZAVCNFSM6AAAAABD22UD5WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNRXGQYTMOJZGM>
> .
> You are receiving this because your review was requested.Message ID:
> ***@***.***>
>


https://github.com/llvm/llvm-project/pull/83052