[llvm] [lldb][llvm] Return an error instead of crashing when parsing a line table prologue. (PR #80769)
David Blaikie via llvm-commits
llvm-commits at lists.llvm.org
Mon Feb 26 15:14:12 PST 2024
================
@@ -823,7 +823,9 @@ TEST_F(DebugLineBasicFixture, ErrorForUnsupportedAddressSizeDefinedInHeader) {
nullptr, RecordRecoverable);
EXPECT_THAT_ERROR(
std::move(Recoverable),
- FailedWithMessage("address size 0x09 of DW_LNE_set_address opcode at "
----------------
dwblaikie wrote:
Looks like this test change removed coverage for a different error message, by failing earlier?
This test should probably be restored by modifying it to be reachable, or the original code's error handling should be turned into an assertion if the diagnostic is now an invariant for the code?
https://github.com/llvm/llvm-project/pull/80769
More information about the llvm-commits
mailing list