[llvm] [SimplifyCFG] Fix hoisting problem in SimplifyCFG (PR #78615)

via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 26 11:14:00 PST 2024


================
@@ -1742,15 +1767,6 @@ bool SimplifyCFGOpt::hoistCommonCodeFromSuccessors(BasicBlock *BB,
       continue;
     }
 
-    SmallVector<Instruction *, 8> OtherInsts;
-    if (SameLevelHoist) { 
----------------
RouzbehPaktinat wrote:

You're right, it makes sense to split the code into 3 steps to address those cases independently. Just as a bug fix, can we merge the current code? I think it covers the problem that was mentioned in the original issue.  I can work on your proposal in a separate PR a bit later :)

https://github.com/llvm/llvm-project/pull/78615


More information about the llvm-commits mailing list