[llvm] [DirectX][NFC] Rename ShaderFlag to Shader_FEATURE_INFO. (PR #82700)

Chris B via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 26 07:34:54 PST 2024


================
@@ -56,7 +56,7 @@ struct DXILProgram {
   std::optional<std::vector<llvm::yaml::Hex8>> DXIL;
 };
 
-#define SHADER_FLAG(Num, Val, Str) bool Val = false;
+#define SHADER_FEATURE_FLAG(Num, Val, Str) bool Val = false;
 struct ShaderFlags {
----------------
llvm-beanz wrote:

I'm not sure I follow your suggestion.

IMO, the macro should match the way it is used. Without your change we have a `SHADER_FLAG` macro that generates `ShaderFlag` structure values. If we're renaming that macro, we should also rename the structure that we generate based on it.

https://github.com/llvm/llvm-project/pull/82700


More information about the llvm-commits mailing list