[llvm] [mlir][bazel] Remove defines of obsolete MLIR_GPU_TO_CUBIN_PASS_ENABLE. (PR #83006)

Ingo Müller via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 26 06:06:38 PST 2024


https://github.com/ingomueller-net created https://github.com/llvm/llvm-project/pull/83006

This macro is obsolete since the landing of #82486 but was forgotten to be removed from the BUILD files.

>From e08f4b533ab76e6c91483ee66a5aed701cfd9a7f Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Ingo=20M=C3=BCller?= <ingomueller at google.com>
Date: Mon, 26 Feb 2024 14:04:44 +0000
Subject: [PATCH] [mlir][bazel] Remove defines of obsolete
 MLIR_GPU_TO_CUBIN_PASS_ENABLE.

This macro is obsolete since the landing of #82486 but was forgotten to
be removed from the BUILD files.
---
 utils/bazel/llvm-project-overlay/mlir/BUILD.bazel      | 1 -
 utils/bazel/llvm-project-overlay/mlir/test/BUILD.bazel | 5 +----
 2 files changed, 1 insertion(+), 5 deletions(-)

diff --git a/utils/bazel/llvm-project-overlay/mlir/BUILD.bazel b/utils/bazel/llvm-project-overlay/mlir/BUILD.bazel
index 59ee03d9a3213f..7c54394a42cc21 100644
--- a/utils/bazel/llvm-project-overlay/mlir/BUILD.bazel
+++ b/utils/bazel/llvm-project-overlay/mlir/BUILD.bazel
@@ -5505,7 +5505,6 @@ cc_library(
     ),
     hdrs = glob(["include/mlir/Dialect/GPU/Transforms/*.h"]),
     includes = ["include"],
-    local_defines = if_cuda_available(["MLIR_GPU_TO_CUBIN_PASS_ENABLE"]),
     deps = [
         ":AffineDialect",
         ":AffineUtils",
diff --git a/utils/bazel/llvm-project-overlay/mlir/test/BUILD.bazel b/utils/bazel/llvm-project-overlay/mlir/test/BUILD.bazel
index 68d9b23fd5643e..7dc7f0e5ccbc05 100644
--- a/utils/bazel/llvm-project-overlay/mlir/test/BUILD.bazel
+++ b/utils/bazel/llvm-project-overlay/mlir/test/BUILD.bazel
@@ -4,7 +4,6 @@
 
 load("@bazel_skylib//rules:expand_template.bzl", "expand_template")
 load("//llvm:lit_test.bzl", "package_path")
-load("//mlir:build_defs.bzl", "if_cuda_available")
 load("//mlir:tblgen.bzl", "gentbl_cc_library", "td_library")
 
 package(
@@ -667,9 +666,7 @@ cc_library(
 cc_library(
     name = "TestGPU",
     srcs = glob(["lib/Dialect/GPU/*.cpp"]),
-    defines = ["MLIR_CUDA_CONVERSIONS_ENABLED"] + if_cuda_available([
-        "MLIR_GPU_TO_CUBIN_PASS_ENABLE",
-    ]),
+    defines = ["MLIR_CUDA_CONVERSIONS_ENABLED"],
     includes = ["lib/Dialect/Test"],
     deps = [
         "//llvm:NVPTXCodeGen",



More information about the llvm-commits mailing list