[llvm] [NFC][RemoveDIs] Have CreateNeg only accept iterators, template for other patches (PR #82999)

[Jeremy Morse via llvm-commits]

================
@@ -270,7 +270,7 @@ static BinaryOperator *CreateMul(Value *S1, Value *S2, const Twine &Name,
 }
 
 static Instruction *CreateNeg(Value *S1, const Twine &Name,
-                              Instruction *InsertBefore, Value *FlagsOp) {
+                              BasicBlock::iterator InsertBefore, Value *FlagsOp) {
   if (S1->getType()->isIntOrIntVectorTy())
     return BinaryOperator::CreateNeg(S1, Name, InsertBefore);
----------------
jmorse wrote:

It looks like I missed adding the definition of the iterator-taking CreateNeg in 76dd4bc036, hence this presents in the diff as the argument-type changing instead of the deletion of the `Instruction *` taking function. That's my bad; but shouldn't be the same for the other scenarios where the `Instruction *` taking functions get removed.

https://github.com/llvm/llvm-project/pull/82999