[llvm] [RemoveDIs] Add iterator-taking constructors and Create methods (PR #82778)

[Orlando Cazalet-Hyams via llvm-commits]

================
@@ -844,6 +1035,13 @@ class CmpInst : public Instruction {
   void *operator new(size_t S) { return User::operator new(S, 2); }
   void operator delete(void *Ptr) { User::operator delete(Ptr); }
 
+  /// Construct a compare instruction, given the opcode, the predicate and
+  /// the two operands. Insert the instruction into a BasicBlock right before
+  /// the specified instruction.
+  /// Create a CmpInst
+  static CmpInst *Create(OtherOps Op, Predicate predicate, Value *S1, Value *S2,
+                         const Twine &Name, BasicBlock::iterator InsertBefore);
----------------
OCHyams wrote:

nit: formatting is different here (for others it looks like the formatting is identical to the Instruction* versions?). Not sure which is correctly clang-formatted, just pointing it out in case it's an accident.

https://github.com/llvm/llvm-project/pull/82778