[llvm] [RemoveDIs] Add iterator-taking constructors and Create methods (PR #82778)

[Orlando Cazalet-Hyams via llvm-commits]

https://github.com/OCHyams approved this pull request.

> However, I figure it's worth /some/ review of the general approach, just to confirm that I haven't missed anything obvious that's going on.

I looked at the whole thing (agree it is quite boring, but I can't imagine it was much more fun to write... thank you!).

What do you think we should do with the Instruction* versions?
* Are there remaining uses in LLVM? If so, should those be updated now/immediately?
* When should they be removed?


LGTM

https://github.com/llvm/llvm-project/pull/82778