[llvm] [python] Bump Python minimum version to 3.8 (PR #78828)

Aiden Grossman via llvm-commits llvm-commits at lists.llvm.org
Sat Feb 17 20:16:14 PST 2024


boomanaiden154 wrote:

> Very interesting. It looks like the same buildkite Windows x64 job now succeeds. For referencing later, it is [buildkite build #37898](https://buildkite.com/llvm-project/github-pull-requests/builds/37898). I'm going to rebase and push again to see if this buildkite build is flaky.

The Windows build (on Buildkite) is disabled currently (more context is available in this PR: https://github.com/llvm/llvm-project/pull/81538 and the discourse thread linked). It's interesting that it started passing. There have been a lot of transient failures on the Windows build that led to failures, so it wouldn't surprise me if this issue ended up being transient.

Given that the CI is disabled, I don't think there's a way to properly test this against the Buildkite Windows CI (well, you might be able to revert the patch from the disable commit in this branch), but that also shouldn't matter if it's disabled. I'm fine with this landing in its current state (especially if it passed the Windows CI before you rebased). The bigger issue either way is probably making sure everything gets past post-commit.

Some stuff within the project is also already on a newer version (https://github.com/llvm/llvm-project/issues/81598), so this landing sooner rather than later would probably be good.

Given that the RFC has consensus and the Windows CI failure is transient, I think we can probably move forward with this. Does anyone else have objections?

https://github.com/llvm/llvm-project/pull/78828


More information about the llvm-commits mailing list