[clang] [llvm] [openmp] [PGO][OpenMP] Instrumentation for GPU devices (PR #76587)
    Johannes Doerfert via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Fri Feb 16 17:03:54 PST 2024
    
    
  
================
@@ -2067,6 +2067,10 @@ Constant *ConstantExpr::getBitCast(Constant *C, Type *DstTy,
 
 Constant *ConstantExpr::getAddrSpaceCast(Constant *C, Type *DstTy,
                                          bool OnlyIfReduced) {
+  // Skip cast if types are identical
----------------
jdoerfert wrote:
@arsenm Wanted to use this one, which requires us to allow no-op casts.
The non-leaf wrappers accept no-op casts, the leaf ones do not. It is unclear if there is a deeper meaning to it, I doubt it.
We probably want to modify them all, in a prep PR, or use the combined interface as before.
@arsenm wdyt?
https://github.com/llvm/llvm-project/pull/76587
    
    
More information about the llvm-commits
mailing list