[compiler-rt] [llvm] [TypeProf][InstrPGO] Introduce raw and instr profile format change for type profiling. (PR #81691)

Mingming Liu via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 16 13:43:34 PST 2024


minglotus-6 wrote:

> > > Also the CI clang-format is complaining so make sure the re-run that on your changes
> > 
> > 
> > clang-format formats existing code (specifically C++ macros) in `InstrProfData.inc` pretty aggressively and the indentations making code hard to read.
> > Taking https://github.com/llvm/llvm-project/actions/runs/7921397694/job/21626608711?pr=81691 as an example, reformatted code between `-/+` line 210 to line 267 are hard to read, same for code between line 284 to line 404, code between 780 to 970, etc
> > Given clang-format only complains about two `InstrProfData.inc`, I'm inclined not to run `git clang-format` to update these two files.
> 
> If that's the case we could ignore these files from `clang-format` via a `.clang-format-ignore` file if you're inclined to make that change.

Thanks for the suggestions! After taking a look, `.clang-format-ignore` isn't used in current repo while `// clang-format off:<reason>` is used (e.g. at 7 different places in this [file](https://github.com/llvm/llvm-project/blob/450462cbaceddf57812ce15b5135b17f65a77654/clang/lib/Analysis/UnsafeBufferUsage.cpp)). I could make possibly add a few `// clang-format off` and `// clang-format on` around c++ macros in an nfc pull request.

Meanwhile, I'll send out a follow up change to update https://llvm.org/docs/InstrProfileFormat.html

https://github.com/llvm/llvm-project/pull/81691


More information about the llvm-commits mailing list