[llvm] llvm-dwarfdump --verify aggregated output to JSON file (PR #81762)

Felipe de Azevedo Piovezan via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 16 08:52:50 PST 2024


================
@@ -834,8 +842,10 @@ int main(int argc, char **argv) {
                           "-verbose is currently not supported";
     return 1;
   }
-  if (!Verify && ErrorDetails != Unspecified)
-    WithColor::warning() << "-error-detail has no affect without -verify";
+  // -error-detail and -json-summary-file both imply -verify
+  if (ErrorDetails != Unspecified || !JsonSummaryFile.empty()) {
+    Verify = true;
----------------
felipepiovezan wrote:

> You've already typed out either 'json-summary-file'
> seem pretty darned explicit to me

Maybe this is a language thing, but what about "json/summary/files" is "darned explicit" that we want to *verify*? 
IMO this reminds us a lot more about statistics than errors

https://github.com/llvm/llvm-project/pull/81762


More information about the llvm-commits mailing list