[llvm] llvm-dwarfdump --verify aggregated output to JSON file (PR #81762)

Kevin Frei via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 16 08:48:44 PST 2024


================
@@ -834,8 +842,10 @@ int main(int argc, char **argv) {
                           "-verbose is currently not supported";
     return 1;
   }
-  if (!Verify && ErrorDetails != Unspecified)
-    WithColor::warning() << "-error-detail has no affect without -verify";
+  // -error-detail and -json-summary-file both imply -verify
+  if (ErrorDetails != Unspecified || !JsonSummaryFile.empty()) {
+    Verify = true;
----------------
kevinfrei wrote:

You've already typed out either 'json-summary-file' or 'error-detail=...' which both seem pretty darned explicit to me. (Just thinking about forcing more typing with no difference in the end result makes my wrists twinge.) But if folks feel strongly, I can change it back...

https://github.com/llvm/llvm-project/pull/81762


More information about the llvm-commits mailing list