[llvm] [LLVM] Add `LLVM_<proj>_RUNTIME_TARGETS` to set targets per-project (PR #81557)

Petr Hosek via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 16 08:29:45 PST 2024


================
@@ -236,6 +236,7 @@ function(runtime_default_target)
   endif()
 
   set_enable_per_target_runtime_dir()
+  set(LLVM_ENABLE_RUNTIMES ${ARG_RUNTIMES})
----------------
petrhosek wrote:

Previously, we would passthrough `LLVM_ENABLE_RUNTIMES` as a global variable, but now we always pass in `RUNTIMES` as a function argument, and then set `LLVM_ENABLE_RUNTIMES` as a local variable shadowing the global one and rely on the passthrough mechanism.

That's quite obscure and potentially error prone, I think we should stop using the passthrough machinery and instead pass `LLVM_ENABLE_RUNTIMES` as an extra argument.

https://github.com/llvm/llvm-project/pull/81557


More information about the llvm-commits mailing list