[llvm] [Release] Don't build during test-release.sh Phase 3 install (PR #82001)

Rainer Orth via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 16 07:43:28 PST 2024


https://github.com/rorth created https://github.com/llvm/llvm-project/pull/82001

As described in [test-release.sh ninja install does builds in Phase 3](https://github.com/llvm/llvm-project/issues/80999), considerable parts of Phase 3 of a `test-release.sh` build are run by `ninja install`, ignoring both `$Verbose` and the parallelism set via `-j NUM`.

This patches fixes this by not specifying any explicit build target for Phase 3, thus running the full build as usual.

Tested on `sparc64-unknown-linux-gnu`.

>From 6b87cfba1c6309fe711dde68303f6a21951cbfe8 Mon Sep 17 00:00:00 2001
From: Rainer Orth <ro at gcc.gnu.org>
Date: Fri, 16 Feb 2024 16:41:28 +0100
Subject: [PATCH] [Release] Don't build during test-release.sh Phase 3 install

As described in [test-release.sh ninja install does builds in Phase
3](https://github.com/llvm/llvm-project/issues/80999), considerable parts
of Phase 3 of a `test-release.sh` build are run by `ninja install`,
ignoring both `$Verbose` and the parallelism set via `-j NUM`.

This patches fixes this by not specifying any explicit build target for
Phase 3, thus running the full build as usual.

Tested on `sparc64-unknown-linux-gnu`.
---
 llvm/utils/release/test-release.sh | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/llvm/utils/release/test-release.sh b/llvm/utils/release/test-release.sh
index c3f4f42314309b..4314b565e11b03 100755
--- a/llvm/utils/release/test-release.sh
+++ b/llvm/utils/release/test-release.sh
@@ -537,6 +537,11 @@ function build_llvmCore() {
         InstallTarget="$InstallTarget install-builtins"
       fi
     fi
+    if [ "$Phase" -eq "3" ]; then
+      # Build everything at once, with the proper parallelism and verbosity,
+      # in Phase 3.
+      BuildTarget=
+    fi
 
     cd $ObjDir
     echo "# Compiling llvm $Release-$RC $Flavor"



More information about the llvm-commits mailing list