[llvm] [InstCombine] Do not simplify lshr/shl arg if it is part of fshl rotate pattern. (PR #73441)

Nikita Popov via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 16 07:23:29 PST 2024


================
@@ -2706,17 +2706,16 @@ Instruction *InstCombinerImpl::matchBSwapOrBitReverse(Instruction &I,
   return LastInst;
 }
 
-/// Match UB-safe variants of the funnel shift intrinsic.
-static Instruction *matchFunnelShift(Instruction &Or, InstCombinerImpl &IC,
-                                     const DominatorTree &DT) {
+std::optional<std::tuple<Intrinsic::ID, SmallVector<Value *, 3>>>
----------------
nikic wrote:

I agree that we should use std::pair instead of std::tuple if there are only two elements.

https://github.com/llvm/llvm-project/pull/73441


More information about the llvm-commits mailing list