[llvm] [RemoveDIs] Print non-intrinsic debug info in textual IR output (PR #79281)
Stephen Tozer via llvm-commits
llvm-commits at lists.llvm.org
Fri Feb 16 06:12:23 PST 2024
================
@@ -234,6 +238,13 @@ class LLVM_EXTERNAL_VISIBILITY Module {
IsNewDbgInfoFormat = false;
}
+ void setIsNewDbgInfoFormat(bool NewFlag) {
+ if (NewFlag && !IsNewDbgInfoFormat)
+ convertToNewDbgValues();
+ else if (!NewFlag && IsNewDbgInfoFormat)
+ convertFromNewDbgValues();
----------------
SLTozer wrote:
Right now, I think I prefer the current approach primarily because it is consistent with the formatting of the equivalent function in `BasicBlock`, so is simpler to understand for someone who views both (rather than appearing to contain different logic) - obviously all these approaches are identical so I'm not attached to any one in particular, right now I just lean more towards the more concise and consistent approach rather than emphasizing simpler conditionals - WDYT?
https://github.com/llvm/llvm-project/pull/79281
More information about the llvm-commits
mailing list